Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout of "i" in admin settings of federated sharing #12823

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

MorrisJobke
Copy link
Member

This moves the "i" out of the <h2> (like all others) and centers it a bit better.

I did this together with @jancborchardt while do the polishing review (#12694)

cc @nextcloud/designers

Before and after:

bildschirmfoto 2018-12-04 um 17 29 35
bildschirmfoto 2018-12-04 um 17 31 18

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Dec 4, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Dec 4, 2018
@MorrisJobke
Copy link
Member Author

/backport to stable15

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me!

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better, thanks!

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 4, 2018
@rullzer rullzer merged commit c654ade into master Dec 4, 2018
@rullzer rullzer deleted the bugfix/noid/polishing-design-federated-settings branch December 4, 2018 18:50
@backportbot-nextcloud
Copy link

backport to stable15 in #12829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants