Use Webdav PUT for uploads #1283

rullzer · 2016-09-06T10:29:29Z

See owncloud/core#21237

Please test carefully:

Test upload via button
Test upload drag/drop
Test upload link share
Test files_drop

CC: @nickvergessen @MorrisJobke @LukasReschke @blizzz @icewind1991 @schiessle

nickvergessen · 2016-09-06T10:48:19Z

Test activities which broke last time we tried this

icewind1991 · 2016-09-06T11:37:39Z

Ok, the name of the PR is misleading since it's implementing webdav POST, not using webdav PUT

From what I understand from reading the spec this is not actually implementing RFC5995 as it says it is, but instead doing something that somewhat looks like the spec on the surface. according to the RFC every collection has a (possibly) separate endpoint where it allows POST requests to create new files in the collection, this endpoint url is static for the collection and does not contain any filename suggestion for the created file, if the client wants to suggest a filename it can use the Slug header.

As it's currently implemented it uses a "magic path" /path/to/folder/&suggested_file_name instead of having a per-collection endpoint for adding files to a collection

Imo it would be better if we properly follow the rfc

rullzer · 2016-09-08T19:23:28Z

@icewind1991 so close this and you fix it according to the RFC ;)?

LukasReschke · 2016-09-26T08:24:01Z

@icewind1991 I'd either like to have this fixed or merged. 🙈

LukasReschke · 2016-09-26T08:26:22Z

Blocks #1511

blizzz · 2016-09-29T12:25:25Z

Needs rebase

MorrisJobke · 2016-10-05T22:28:10Z

@icewind1991 @rullzer How to proceed here? stalled PRs doesn't help neither.

LukasReschke · 2016-10-06T09:08:13Z

Rebase and just merge and enhance latter? Keeps the diff smaller 🙈

LukasReschke · 2016-10-06T09:09:43Z

Will rebase.

icewind1991 · 2016-10-10T12:04:33Z

I'm fine with this as long as it has some documentation about how the magic path works (and doesn't suggest it's RFC5995)

MorrisJobke · 2016-10-20T14:56:02Z

I rebased this and want to get this in, because it blocks soo many other downstream PRs.

MorrisJobke · 2016-10-20T15:00:11Z

fix anonymous upload feature (files/ajax/upload.php doesn't exist anymore)

rullzer · 2016-10-23T18:58:14Z

Files_drop is kind of working again.

@icewind1991 do you agree with 35f9d3c Else it is not possible to upload via webdav with only create permissions since rename is not allowed.

nickvergessen · 2016-10-24T09:39:01Z

Some tests are failing

- uses PUT method with jquery.fileupload for regular and public file lists - for IE and browsers that don't support it, use POST with iframe transport - implemented Sabre plugin to handle iframe transport and redirect the embedded PUT request to the proper handler - added RFC5995 POST to file collection with "add-member" property to make it possible to auto-rename conflicting file names - remove obsolete ajax/upload.php and obsolete ajax routes Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Not needed any more in IE >= 11 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Hacked around Blueimp's jquery.fileupload to make it work with our new chunking API. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

If we move a file from the temp part file to the original file we don't need update permissions. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

codecov-io · 2016-10-24T21:58:59Z

Current coverage is 57.35% (diff: 36.36%)

Merging #1283 into master will increase coverage by 0.07%

@@             master      #1283   diff @@
==========================================
  Files          1075       1075          
  Lines         61319      61975   +656   
  Methods        6851       6960   +109   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          35124      35546   +422   
- Misses        26195      26429   +234   
  Partials          0          0

Diff Coverage	File Path
0%	apps/dav/appinfo/v1/publicwebdav.php
0%	apps/files/templates/list.php
0%	new apps/dav/lib/Files/Sharing/FilesDropPlugin.php
•••••••• 80%	...ib/private/Files/Storage/Wrapper/PermissionsMask.php
•••••••• 88%	apps/dav/lib/Connector/Sabre/FilesPlugin.php
•••••••••• 100%	apps/files/appinfo/routes.php

Powered by Codecov. Last update 8a231a4...c8a13f6

rullzer · 2016-10-25T06:11:55Z

Ok files_drop works here.
Lets get this in and fiddle with the details later.

CC: @MorrisJobke @icewind1991 @nickvergessen @LukasReschke @blizzz

MorrisJobke · 2016-10-25T08:24:40Z

Works 👍

Tested in IE, Safari and Chrome

MorrisJobke · 2016-10-25T08:25:11Z

@LukasReschke @nickvergessen we should get this in as fast as possible - other downstreams are depending on this

LukasReschke · 2016-10-25T08:30:57Z

LGTM

rullzer added enhancement 3. to review Waiting for reviews downstream labels Sep 6, 2016

rullzer added this to the Nextcloud 11.0 milestone Sep 6, 2016

LukasReschke mentioned this pull request Sep 26, 2016

Remove upload_limit in files app as it is not needed with PUT upload #1511

Merged

1 task

rullzer assigned rullzer and icewind1991 and unassigned rullzer Oct 2, 2016

nickvergessen added 1. to develop Accepted and waiting to be taken care of and removed 3. to review Waiting for reviews labels Oct 6, 2016

MorrisJobke force-pushed the us_files-ui-webdav-upload branch from 95e3183 to 34a61bd Compare October 20, 2016 14:55

rullzer force-pushed the us_files-ui-webdav-upload branch from 34a61bd to 2724b60 Compare October 22, 2016 20:14

rullzer force-pushed the us_files-ui-webdav-upload branch from 2724b60 to 76c133c Compare October 24, 2016 13:43

Vincent Petry added 3 commits October 24, 2016 21:45

JS utility function to compare paths

25d9dce

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Goodbye Iframe transport !

c68e273

Not needed any more in IE >= 11 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Vincent Petry and others added 7 commits October 24, 2016 21:45

Add support for chunked upload

786e858

Hacked around Blueimp's jquery.fileupload to make it work with our new chunking API. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Fix js unit tests for webdav put upload changes

f72ffa2

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

More fixes to file upload

f374eb5

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Fix permision mask

e73a11d

If we move a file from the temp part file to the original file we don't need update permissions. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Make files_drop work

7a6dbeb

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Fix public files_drop page

0abcc63

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Only enable files_drop plugin when we actuall do files_drop

c8a13f6

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer force-pushed the us_files-ui-webdav-upload branch from 76c133c to c8a13f6 Compare October 24, 2016 19:45

rullzer added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Oct 25, 2016

LukasReschke merged commit 79706e0 into master Oct 25, 2016

LukasReschke deleted the us_files-ui-webdav-upload branch October 25, 2016 08:31

korelstar mentioned this pull request Feb 11, 2017

[Work in Progress] 3rd-party API: ETag for faster synchronization nextcloud/notes#51

Closed

kesselb mentioned this pull request Sep 4, 2019

Highly unusual dot files in URLs #17005

Closed

karl-in-office mentioned this pull request Dec 11, 2019

Chunked upload not working (Files larger than 10MB) #8802

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Webdav PUT for uploads #1283

Use Webdav PUT for uploads #1283

rullzer commented Sep 6, 2016 •

edited

Loading

nickvergessen commented Sep 6, 2016

icewind1991 commented Sep 6, 2016

rullzer commented Sep 8, 2016

LukasReschke commented Sep 26, 2016

LukasReschke commented Sep 26, 2016

blizzz commented Sep 29, 2016

MorrisJobke commented Oct 5, 2016

LukasReschke commented Oct 6, 2016

LukasReschke commented Oct 6, 2016

icewind1991 commented Oct 10, 2016

MorrisJobke commented Oct 20, 2016

MorrisJobke commented Oct 20, 2016 •

edited by rullzer

Loading

rullzer commented Oct 23, 2016

nickvergessen commented Oct 24, 2016

codecov-io commented Oct 24, 2016

rullzer commented Oct 25, 2016

MorrisJobke commented Oct 25, 2016

MorrisJobke commented Oct 25, 2016

LukasReschke commented Oct 25, 2016

Use Webdav PUT for uploads #1283

Use Webdav PUT for uploads #1283

Conversation

rullzer commented Sep 6, 2016 • edited Loading

nickvergessen commented Sep 6, 2016

icewind1991 commented Sep 6, 2016

rullzer commented Sep 8, 2016

LukasReschke commented Sep 26, 2016

LukasReschke commented Sep 26, 2016

blizzz commented Sep 29, 2016

MorrisJobke commented Oct 5, 2016

LukasReschke commented Oct 6, 2016

LukasReschke commented Oct 6, 2016

icewind1991 commented Oct 10, 2016

MorrisJobke commented Oct 20, 2016

MorrisJobke commented Oct 20, 2016 • edited by rullzer Loading

rullzer commented Oct 23, 2016

nickvergessen commented Oct 24, 2016

codecov-io commented Oct 24, 2016

Current coverage is 57.35% (diff: 36.36%)

rullzer commented Oct 25, 2016

MorrisJobke commented Oct 25, 2016

MorrisJobke commented Oct 25, 2016

LukasReschke commented Oct 25, 2016

rullzer commented Sep 6, 2016 •

edited

Loading

MorrisJobke commented Oct 20, 2016 •

edited by rullzer

Loading