Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] Fix password confirmation lib for ie11 #12863

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 5, 2018

Fixes #12806 for Nextcloud 15.

The previous version did not convert arrow functions to es5 functions. Ref nextcloud-libraries/nextcloud-password-confirmation#2.

@skjnldsv could you verify it works on IE?

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 5, 2018
@MorrisJobke
Copy link
Member

@ChristophWurst What about master?

@MorrisJobke MorrisJobke mentioned this pull request Dec 5, 2018
12 tasks
@MorrisJobke MorrisJobke merged commit 61c17b5 into stable15 Dec 5, 2018
@MorrisJobke MorrisJobke deleted the fix/stable15-fix-password-confirmation-ie11 branch December 5, 2018 23:05
@ChristophWurst
Copy link
Member Author

@ChristophWurst What about master?

Fixed via #12859 (comment).

@ChristophWurst
Copy link
Member Author

@skjnldsv could you verify it works on IE?

Can I take your positive review as a yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: settings feature: users and groups regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants