Fix redundant urldecode()

[soudis]

Fixes #6822

[skjnldsv]

Thanks for your contribution, please sign your work when committing!

https://github.com/nextcloud/appstore/blob/master/CONTRIBUTING.md#sign-your-work

[soudis]

is it sufficient to do this here?

Signed-off-by: Florian Humer soudis@gmx.at

[skjnldsv]

@soudis for such small change, yes! 👍 😉

[MorrisJobke]

Unit tests fail:

1) Tests\Core\Controller\LoginControllerTest::testLoginWithoutPassedCsrfCheckAndLoggedIn
Expectation failed for method name is equal to "getAbsoluteURL" when invoked 1 time(s)
Parameter 0 for invocation OCP\IURLGenerator::getAbsoluteURL('another%20url'): string does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'another url'
+'another%20url'

/drone/src/github.com/nextcloud/server/core/Controller/LoginController.php:254
/drone/src/github.com/nextcloud/server/core/Controller/LoginController.php:287
/drone/src/github.com/nextcloud/server/tests/Core/Controller/LoginControllerTest.php:558

2) Tests\Core\Controller\LoginControllerTest::testLoginWithValidCredentialsAndRedirectUrl
Expectation failed for method name is equal to "getAbsoluteURL" when invoked 1 time(s)
Parameter 0 for invocation OCP\IURLGenerator::getAbsoluteURL('another%20url'): string does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'another url'
+'another%20url'

/drone/src/github.com/nextcloud/server/core/Controller/LoginController.php:254
/drone/src/github.com/nextcloud/server/core/Controller/LoginController.php:373
/drone/src/github.com/nextcloud/server/tests/Core/Controller/LoginControllerTest.php:595

[ChristophWurst]

Apparently this was submitted twice, so I closed the other PR #10681.

[leonklingele-work]

This fixes an issue where logged out users accessing
/ocs/v2.php/cloud/users/details?search=leon%3Ftest are redirected to
/ocs/v2.php/cloud/users/details?search=leon?test after logging in whereas
/ocs/v2.php/cloud/users/details?search=leon%3Ftest is the correct redirect URL.

[soudis]

I do not really know the whole unit test area of this project very well, e.g. how they come about and who makes them, but it seems that the unit test that is failing is tailored to the current wrong behaviour of this function. Can a more experienced person take on this and have a look? The unit test is the only thing blocking this change to finally get in. @ChristophWurst maybe?

Also @leonklingele-work now also found a case where this is a problem without the discoursesso app.

Thanks in advance!

[nickvergessen]

Since the origin repo does not exist anymore, someone needs to redo the patch

[leonklingele-work]

$ wget -qO- https://github.com/nextcloud/server/pull/13137.patch | git am

?

[nickvergessen]

Feel free to do it and also fix the tests while you are on it:
#13137 (comment)