-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use npm for js depdencies, bundle with webpack #13156
Conversation
I guess we'd want to leave that one separate. As it is huge. |
Hugely unmaintained? https://github.com/dropbox/zxcvbn/commits/master |
Found https://www.npmjs.com/package/asdfgh. That might be a nice replacement one day. |
👍 would probably make most sense if strengthify uses that directly in a package etc. |
bde0cd5
to
44c50a2
Compare
Impressive!
… and that even includes more scripts and styles 🚀 |
This one lib needs special treatment. It's not used directly but loaded dynamically (as @rullzer commted above due to its size). Hence I would propose to leave it vendored, open an enhancement ticket and fix this later on. This PR is already huge and I don't want to start touching any scripts. |
cc @nextcloud/javascript for review/testing :) |
🚀! So I guess at certain places we can remove additional scripts loaded etc. So far I did not notice anything doing 💥 yet! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
…effects Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
d5c6cf8
to
96102c1
Compare
Rebased and pushed a fix for the select2 result list. Really nice @ChristophWurst 👍 |
This comment has been minimized.
This comment has been minimized.
"modules": false, | ||
"targets": { | ||
"browsers": [ | ||
"last 2 versions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just reminded me https://jamie.build/last-2-versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah … we can improve that later 😉
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍 Tested and works 👍
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Fixed. This was apparently an issue with 3.4.5 (the latest 3.4 version from npm). Updating to 3.4.8 (the version installed via bower) via git fixed the issue 🚀 |
Let's see if https://drone.nextcloud.com/nextcloud/server/14389/248 is working. |
Yes it does \o/ |
Hi @ChristophWurst - I saw above you included |
Fixes #13071
Checklist:
-> not available on npminstalled via githubbreaks somehowdoesn't anymoreonly newer, not working versions on npmfound oneno npm package NPM package? strengthify#17made it one Make this a npm package strengthify#25(Based on https://github.com/nextcloud/server/blob/ad9ece4e4839297e50d34bb50481a78407f6b835/bower.json)