Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Force var to be integer #13321

Merged
merged 1 commit into from
Jan 3, 2019
Merged

[stable14] Force var to be integer #13321

merged 1 commit into from
Jan 3, 2019

Conversation

ArtificialOwl
Copy link
Member

This is a backport of a bug fixed in 15 while implementation of #12105

@ArtificialOwl
force var to be integer
bdf5c93 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl changed the title Force var to be integer [stable14] Force var to be integer Jan 2, 2019
@ArtificialOwl ArtificialOwl requested a review from danxuliu January 2, 2019 10:51
@ArtificialOwl ArtificialOwl added bug 3. to review Waiting for reviews labels Jan 2, 2019
@ArtificialOwl ArtificialOwl added this to the Nextcloud 14.0.5 milestone Jan 2, 2019
MorrisJobke
MorrisJobke approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke MorrisJobke merged commit 25fe43f into stable14 Jan 3, 2019
@MorrisJobke MorrisJobke deleted the bugfix/noid/backport-of-issues-fixed-in-12105 branch January 3, 2019 09:41
@MorrisJobke MorrisJobke mentioned this pull request Jan 4, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 14.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtificialOwl @rullzer @MorrisJobke