Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14][3rdparty] Broker: add timezone to CANCEL messages #13385

Merged
merged 1 commit into from
Jan 14, 2019
Merged

[stable14][3rdparty] Broker: add timezone to CANCEL messages #13385

merged 1 commit into from
Jan 14, 2019

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jan 5, 2019 •
edited by rullzer
Loading

@kesselb kesselb added the 3. to review Waiting for reviews label Jan 5, 2019
@kesselb kesselb added this to the Nextcloud 14.0.6 milestone Jan 5, 2019
@kesselb kesselb mentioned this pull request Jan 5, 2019
Merged
1 task
rullzer
rullzer requested changes Jan 6, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked till 14.0.9 is out

@kesselb @rullzer
[3rdparty] Broker: add timezone to CANCEL messages
a0d1aba 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@rullzer rullzer force-pushed the 3rdparty/broker-add-timezone-cancel-message-stable14 branch from 257bc52 to a0d1aba Compare January 10, 2019 19:10
@ChristophWurst
Copy link
Member

What ticket/issue does this fix? Can't find any reference in the original PR.

@kesselb
Copy link
Contributor Author

kesselb commented Jan 11, 2019 •
edited
Loading

#12946 author of this pull request described some troubles with Outlook and cancel messages. Fixed by this patch from sabre.

MorrisJobke
MorrisJobke approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobke MorrisJobke merged commit 64b3ac6 into stable14 Jan 14, 2019
@MorrisJobke MorrisJobke deleted the 3rdparty/broker-add-timezone-cancel-message-stable14 branch January 14, 2019 10:47
@MorrisJobke MorrisJobke mentioned this pull request Jan 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@georgehrke georgehrke Awaiting requested review from georgehrke

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: dependencies
Projects
None yet
Milestone
Nextcloud 14.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@kesselb @ChristophWurst @rullzer @MorrisJobke