Fix colorizeSvg with transformations that contain a comma (,) #13650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added a commit
to nextcloud/spreed
that referenced
this pull request
Jan 17, 2019
… dark theme Actual fix is adjusting the regex on the server, allowing commas in the first regex: nextcloud/server#13650 Signed-off-by: Joas Schilling <coding@schilljs.com>
jancborchardt
approved these changes
Jan 17, 2019
skjnldsv
approved these changes
Jan 17, 2019
|
/backport to stable15 |
|
/backport to stable14 |
backportbot-nextcloud bot
pushed a commit
to nextcloud/spreed
that referenced
this pull request
Jan 17, 2019
… dark theme Actual fix is adjusting the regex on the server, allowing commas in the first regex: nextcloud/server#13650 Signed-off-by: Joas Schilling <coding@schilljs.com>
juliusknorr
approved these changes
Jan 17, 2019
|
Failure unrelated: https://drone.nextcloud.com/nextcloud/server/14813/234 |
juliusknorr
added
4. to release
skjnldsv
deleted the
bugfix/noid/fix-colorizeSvg-with-transformations-containing-commas
branch
|
backport to stable15 in #13653 |
|
The backport to stable14 failed. Please do this backport manually. |
|
Stable14 #13654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref nextcloud/spreed#1451 (comment)