[stable15] Improve data directory write checking for NFS mounts #13906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
If `is_writable()` fails, fall back to logic that attempts to create a file and then checks if it exists. If this check fails, an error occurs as it did before. Discussion on this solution was found here: https://help.nextcloud.com/t/write-errors-for-nfs-mount/23328 Fixes #7124 Signed-off-by: Robert Dailey <rcdailey@gmail.com>
Merged
rullzer
requested review from
MorrisJobke,
kesselb,
nickvergessen,
blizzz,
ChristophWurst and
juliusknorr
rullzer
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #13237