Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing spaces from localized strings #14221

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

MorrisJobke
Copy link
Member

I noticed this because some translations are missing the trailing space and thus the text is squeezed together.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Feb 15, 2019
@MorrisJobke MorrisJobke added this to the Nextcloud 16 milestone Feb 15, 2019
@MorrisJobke
Copy link
Member Author

/backport to stable15

@MorrisJobke
Copy link
Member Author

/backport to stable14

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also remove the cast to string

@MorrisJobke
Copy link
Member Author

Can also remove the cast to string

I would do that in a followup PR to be able to not backport this then.

@MorrisJobke MorrisJobke merged commit bf19431 into master Feb 15, 2019
@MorrisJobke MorrisJobke deleted the fix/noid/no-trailing-spaces-in-l10n-strings branch February 15, 2019 12:42
@backportbot-nextcloud
Copy link

backport to stable15 in #14225

@backportbot-nextcloud
Copy link

backport to stable14 in #14226

@nickvergessen
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants