Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix personal settings fed scope tabindex #14808

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Fix personal settings fed scope tabindex #14808

merged 2 commits into from
Mar 25, 2019

Conversation

ChristophWurst
Copy link
Member

Fixes Personal info: Federation scope menu toggle not selectable via keyboard from #14639.

This is not a regression but I think this was never possible before. It somewhat works now, but it's not perfect.

@ChristophWurst
Fix tabindex and meno open/close via keyboard on fed scope menu
f127de0 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Make the federation scope selectable via keyboard
5926ff9 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Mar 22, 2019
@ChristophWurst ChristophWurst self-assigned this Mar 22, 2019
@jancborchardt jancborchardt mentioned this pull request Mar 22, 2019
Closed
62 tasks
MorrisJobke
MorrisJobke approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works better than before 👍

rullzer
rullzer approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this 🚀
Small 🚬 test didn't blow up :)

@rullzer rullzer merged commit 4ce191b into master Mar 25, 2019
@rullzer rullzer deleted the fix/personal-settings-fed-scope-tabindex branch March 25, 2019 08:40
@rullzer rullzer mentioned this pull request Mar 26, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews feature: accessibility feature: settings
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @rullzer @MorrisJobke