Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event dispatcher to OCP #15777

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Add event dispatcher to OCP #15777

merged 1 commit into from
Jun 25, 2019

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 28, 2019 •
edited
Loading

This is an overhaul of the event system. It's a thin abstraction over the Symfony event system, re-exported for apps with a little helper for DI.

  • Adds an Event abstraction to OCP
  • Adds an IEventListener interface
  • Adds an ServiceEventListener helper that routes events to event listeners lazy loaded by the DI container

@ChristophWurst ChristophWurst added this to the Nextcloud 17 milestone May 28, 2019
@ChristophWurst ChristophWurst self-assigned this May 28, 2019
@ChristophWurst ChristophWurst mentioned this pull request May 28, 2019
Merged
3 tasks
@ChristophWurst ChristophWurst marked this pull request as ready for review May 29, 2019 08:49
@ChristophWurst ChristophWurst force-pushed the feature/ocp-event-dispatcher branch from d322353 to 76012fe Compare June 19, 2019 12:53
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 19, 2019
@ChristophWurst
Copy link
Member Author

This should be good to go :)

@georgehrke georgehrke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 24, 2019
@rullzer

This comment has been minimized.

Sign in to view
@ChristophWurst
Add event dispatcher to OCP
3174012 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the feature/ocp-event-dispatcher branch from 76012fe to 3174012 Compare June 25, 2019 08:02
@rullzer rullzer merged commit 5fbf304 into master Jun 25, 2019
@rullzer rullzer deleted the feature/ocp-event-dispatcher branch June 25, 2019 09:48
@MorrisJobke MorrisJobke mentioned this pull request Jul 7, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke approved these changes

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@blizzz blizzz Awaiting requested review from blizzz

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @rullzer @georgehrke