-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidebar icon we use in Talk and Viewer already #15997
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
I'm not sold on the icon choice 🤔 @juliushaertl @ChristophWurst @georgehrke thoughts? |
I agree with @skjnldsv, while the hamburger icon is a good indicator, the people icon looks a bit wrong here. The sidebar is more about details of the file or "object" an app presents. A list of people is only one type of that. How about using a hamburger icon with either a small i which is probably a good pictogram to indicate that there is more information? |
The icon is meant to denote that it’s a menu, and there’s also stuff regarding people in it. Most of the details like activity, comments, sharing relate to people. And one of the most important tasks of the icon is to let people know that this is the thing they have to click to get to sharing. … which is why currently we use this "Sharing" icon, which is too extreme in one direction. And a more generic icon like a list with an info-i would go into the other extreme and downplay the "people" aspect and leave people confused as to how to share. So I’d say this icon change here goes a good step in the right direction. |
I like 4 most 👍 |
While 4 looks nice, there’s some issues with all of them:
|
Case in point, we have people being confused about how to get to the chat and collaboration features when they are in Collabora: An even more generic icon will not help here but make it worse. We all know what the sidebar has to offer, but people who don’t work every day with Nextcloud do not. That’s why the icon has to be iconographic. |
This is exactly like what the icon you suggested does. Contains a list of contacts (from talk)
Also valid for your icon choice. Why is there a contact list in the header?
I have no example of a website using a sidebar icon 🤔
Same as your first icon. |
So @skjnldsv and I discussed and will go for the solution in this pull request for now as we’re in a deadlock otherwise. |
/backport to stable16 |
backport to stable16 in #16287 |
Backport canceled because of #16287 (comment) |
Just housekeeping so we don’t need to add it to every app individually. Ref nextcloud/viewer#142
Please review @nextcloud/designers :) We should probably also backport this to stable16 since it’s low-risk and then we need to handle less backward compatibility.