Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidebar icon we use in Talk and Viewer already #15997

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

jancborchardt
Copy link
Member

Just housekeeping so we don’t need to add it to every app individually. Ref nextcloud/viewer#142

Please review @nextcloud/designers :) We should probably also backport this to stable16 since it’s low-risk and then we need to handle less backward compatibility.

viewer icons

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@skjnldsv
Copy link
Member

skjnldsv commented Jun 18, 2019

I'm not sold on the icon choice 🤔
For me it look like a list of contacts. It make sense in talk because the sidebar is where the list is, but in server it doesn't. Could we find something more generic?

@juliushaertl @ChristophWurst @georgehrke thoughts?

@juliusknorr
Copy link
Member

I agree with @skjnldsv, while the hamburger icon is a good indicator, the people icon looks a bit wrong here. The sidebar is more about details of the file or "object" an app presents. A list of people is only one type of that.

How about using a hamburger icon with either a small i which is probably a good pictogram to indicate that there is more information?

@jancborchardt
Copy link
Member Author

The icon is meant to denote that it’s a menu, and there’s also stuff regarding people in it. Most of the details like activity, comments, sharing relate to people. And one of the most important tasks of the icon is to let people know that this is the thing they have to click to get to sharing.

… which is why currently we use this "Sharing" icon, which is too extreme in one direction. And a more generic icon like a list with an info-i would go into the other extreme and downplay the "people" aspect and leave people confused as to how to share.

So I’d say this icon change here goes a good step in the right direction.

@skjnldsv
Copy link
Member

skjnldsv commented Jun 19, 2019

So I’d say this icon change here goes a good step in the right direction.

I agree, but not with this icon 😉
A few suggestions:

1 2 3 4
sidebar sidebar sidebar sidebar

Any thoughts? :)

I kinda like this one:

normal a bit bigger one
cloud nextcloud com_apps_files__dir=_ fileid=437906 (1) cloud nextcloud com_apps_files__dir=_ fileid=437906

@skjnldsv skjnldsv requested a review from ChristophWurst June 19, 2019 06:26
@georgehrke
Copy link
Member

I like 4 most 👍

@jancborchardt
Copy link
Member Author

While 4 looks nice, there’s some issues with all of them:

  • It is not very iconographic, but a visual representation of the sidebar. It focuses on what it looks like, not what it does.
  • On mobile, the sidebar does not look like that.
  • If you don’t know what the sidebar has, you have no context of what will await you.
  • It’s quite generic, like only a "Fullscreen" icon could do.
  • Does any other popular app use an icon comparable to this?
  • It doesn’t answer the question "What do I need to click to share this thing with someone?"

@jancborchardt
Copy link
Member Author

Case in point, we have people being confused about how to get to the chat and collaboration features when they are in Collabora:
https://github.com/nextcloud/server/issues/15386

An even more generic icon will not help here but make it worse. We all know what the sidebar has to offer, but people who don’t work every day with Nextcloud do not. That’s why the icon has to be iconographic.

@skjnldsv
Copy link
Member

  • It is not very iconographic, but a visual representation of the sidebar. It focuses on what it looks like, not what it does.

This is exactly like what the icon you suggested does. Contains a list of contacts (from talk)

  • On mobile, the sidebar does not look like that.
  • If you don’t know what the sidebar has, you have no context of what will await you.

Also valid for your icon choice. Why is there a contact list in the header?

  • It’s quite generic, like only a "Fullscreen" icon could do.
  • Does any other popular app use an icon comparable to this?

I have no example of a website using a sidebar icon 🤔

  • It doesn’t answer the question "What do I need to click to share this thing with someone?"

Same as your first icon.

@jancborchardt
Copy link
Member Author

So @skjnldsv and I discussed and will go for the solution in this pull request for now as we’re in a deadlock otherwise.

@jancborchardt jancborchardt merged commit e558cb2 into master Jun 21, 2019
@jancborchardt jancborchardt deleted the design/sidebar-icon branch June 21, 2019 21:14
@MorrisJobke
Copy link
Member

/backport to stable16

@backportbot-nextcloud
Copy link

backport to stable16 in #16287

@MorrisJobke
Copy link
Member

Backport canceled because of #16287 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants