Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tense in email #16163

Merged
merged 3 commits into from
Jul 1, 2019
Merged

Fix tense in email #16163

merged 3 commits into from
Jul 1, 2019

Conversation

wernerfred
Copy link
Contributor

Change send to sent in the following line:

$bodyPart = $this->l->t('You just shared »%1$s« with %2$s. The share was already send to the recipient. Due to the security policies defined by the administrator of %3$s each share needs to be protected by password and it is not allowed to send the password directly to the recipient. Therefore you need to forward the password manually to the recipient.', [$filename, $shareWith, $this->defaults->getName()]);

and adapt all l10n files that contained the sentences appropriate

This PR closes #16119 if accepted

@kesselb
Copy link
Contributor

kesselb commented Jun 30, 2019

Thank you 🎉

Translations are managed with transifex (https://www.transifex.com/nextcloud/nextcloud/) and synced daily to this repository. Could you please revert the l10n files?

Signed-off-by: Frederic Werner <frederic-github@werner-net.work>
Signed-off-by: Frederic Werner <frederic-github@werner-net.work>
This reverts commit 7ed0d09.

Signed-off-by: Frederic Werner <frederic-github@werner-net.work>
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Maybe squash the commits but otherwise, no other issues.

@wernerfred wernerfred added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 30, 2019
@skjnldsv skjnldsv merged commit 1224869 into nextcloud:master Jul 1, 2019
@MorrisJobke
Copy link
Member

/backport to stable16

@MorrisJobke
Copy link
Member

/backport to stable15

@backportbot-nextcloud
Copy link

The backport to stable16 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable15 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share By Mail Spelling Mistake
5 participants