Ignore forbidden exception when fetching share mtime on SMB for symlinks #16195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 2, 2019
rullzer
reviewed
Jul 3, 2019
| @@ -302,6 +302,8 @@ private function shareMTime() { | |||
| } | |||
| } catch (NotFoundException $e) { | |||
| // Ignore this, can happen on unavailable DFS shares | |||
| } catch (ForbiddenException $e) { | |||
| // Ignore this too - it's a symlink | |||
There was a problem hiding this comment.
My SMB knowledge is not good enough.
But is forbidden always a symlink?
There was a problem hiding this comment.
At least it shows a folder where you don't have permissions. In general it's not really nice, because what happens if you create a folder that is already in there, but hidden in this way? On the other side: this is the code for fetching the share mtime and not the one for directory listing (which happened before then).
icewind1991
approved these changes
Jul 8, 2019
rullzer
approved these changes
Jul 8, 2019
See #7556 (comment) Signed-off-by: Morris Jobke <hey@morrisjobke.de>
rullzer
force-pushed
the
bugfix/7556/smb-symlink-share-mtime
branch
from
d24c872 to
adc2ab4
Compare
rullzer
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7556 (comment)