Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master]New Password Welcome form : Activate and choose initial password for new provisioned user #16260

Conversation

compagnon
Copy link
Contributor

Duplicate Proposal for #16245
(#16251 is pulled on stable 16 ( 16.0.1) )
pulled on MASTER ( $OC_VersionString = '17.0.0 alpha';)
Committer: same person - @gcompagnon @compagnon

/newpassword
/newpassword/email
/newpassword/userid
would provide a dedicated welcome page for new users , letting them enter the same process than Lost Password (new password feature is implemented into LostController)
This URL could be used into a customized Welcome email in a simple way for Business people/sales.

The new user could use that URL to choose his password, and the form could be customized to make user to accept conditions of use.

image
If the user has never login(is enabled) => this is a First connection
image

If the user returns, on that URL: this is a Lost Password form
image

  • I have added also an administrator_email property on the config.php to display 'mailto' link to the * administrator email with the user id. l have updated some i10n messages for using that info instead of a "Administrator" , user knows the email.
  • Anti spam is enabled with throttle_delay

Here is an exception management example: a mailto on the administrator email is enabled
image

*
* 'administrator_email' => 'support@nextcloud.com',
*/
'administrator_email' => 'your administrator email',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some kind of fallback? Whats happens if the value is not set? If we decided to add such option we should do it in a more general way. Some people will use a ticket system, a phone number or "Administrator". Let's wait for another reviewer for a second opinion but this looks like another story.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The need is for users not capable to login , giving a mailto: link for sending UID and error message to an email. If the config is not set up, it will create an email with "your administrator email" in the To
Not a big deal. Phone number is a good idea also, to provide in case of server error a

section with all the manner to contact the admin of Nextcloud.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'administrator_email' is used into i10n messages of the newpassword form but it should be good to replace all the IMHO useless "contact your admin" messages . in others forms (… nevertheless some refactoring work in lot of files ...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should do this in a separate issue / pull request. People will use it and ask why it does not work at x or y. If you don't add administrator_email to your config.php it will crash with your current implementation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done with the pull request : #16329

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for another reviewer for a second opinion but this looks like another story.

Please wait for feedback from another reviewer. @MorrisJobke @jancborchardt

core/Controller/LostController.php Show resolved Hide resolved
core/Controller/LostController.php Outdated Show resolved Hide resolved
core/Controller/LostController.php Outdated Show resolved Hide resolved
core/Controller/LostController.php Outdated Show resolved Hide resolved
core/Controller/LostController.php Outdated Show resolved Hide resolved
core/Controller/LostController.php Outdated Show resolved Hide resolved
core/Controller/LostController.php Outdated Show resolved Hide resolved
core/Controller/LostController.php Outdated Show resolved Hide resolved
core/Controller/LostController.php Show resolved Hide resolved
core/l10n/fr.js Outdated Show resolved Hide resolved
@kesselb
Copy link
Contributor

kesselb commented Jul 6, 2019

Pushed ci by reverting the l10n files.

@compagnon compagnon force-pushed the feature/16245/new-password-form_on_master branch from 8e186d6 to 1d73582 Compare July 8, 2019 14:01
@compagnon compagnon changed the title [master]New Password Welcome form : Activate and choose intial password for new provisioned user [master]New Password Welcome form : Activate and choose initial password for new provisioned user Jul 9, 2019
core/l10n/fr.json Outdated Show resolved Hide resolved
@compagnon compagnon force-pushed the feature/16245/new-password-form_on_master branch 2 times, most recently from 7a9a2f0 to 0db2574 Compare July 10, 2019 12:13
Signed-off-by: Guillaume Compagnon <gcompagnon@outlook.com>
@compagnon compagnon force-pushed the feature/16245/new-password-form_on_master branch from 0db2574 to 3ccbb12 Compare July 10, 2019 12:16
Signed-off-by: Guillaume Compagnon <gcompagnon@outlook.com>
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds and looks good, but can't review the code and the PR would need to be updated.

@skjnldsv skjnldsv removed the 3. to review Waiting for reviews label Feb 27, 2024
@skjnldsv
Copy link
Member

As there is no feedback since a while I will close this ticket.
If you will decide to work on this feature again and if it hasn't been fixed or implemented already, feel free to re-open and solve the various conflicts.

Thanks for the interest in Nextcloud and the effort put into this! 🙇

@skjnldsv skjnldsv closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants