-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master]New Password Welcome form : Activate and choose initial password for new provisioned user #16260
[master]New Password Welcome form : Activate and choose initial password for new provisioned user #16260
Conversation
config/config.sample.php
Outdated
* | ||
* 'administrator_email' => 'support@nextcloud.com', | ||
*/ | ||
'administrator_email' => 'your administrator email', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some kind of fallback? Whats happens if the value is not set? If we decided to add such option we should do it in a more general way. Some people will use a ticket system, a phone number or "Administrator". Let's wait for another reviewer for a second opinion but this looks like another story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The need is for users not capable to login , giving a mailto: link for sending UID and error message to an email. If the config is not set up, it will create an email with "your administrator email" in the To
Not a big deal. Phone number is a good idea also, to provide in case of server error a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'administrator_email' is used into i10n messages of the newpassword form but it should be good to replace all the IMHO useless "contact your admin" messages . in others forms (… nevertheless some refactoring work in lot of files ...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should do this in a separate issue / pull request. People will use it and ask why it does not work at x or y. If you don't add administrator_email
to your config.php it will crash with your current implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done with the pull request : #16329
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for another reviewer for a second opinion but this looks like another story.
Please wait for feedback from another reviewer. @MorrisJobke @jancborchardt
Pushed ci by reverting the l10n files. |
8e186d6
to
1d73582
Compare
7a9a2f0
to
0db2574
Compare
Signed-off-by: Guillaume Compagnon <gcompagnon@outlook.com>
0db2574
to
3ccbb12
Compare
Signed-off-by: Guillaume Compagnon <gcompagnon@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds and looks good, but can't review the code and the PR would need to be updated.
As there is no feedback since a while I will close this ticket. Thanks for the interest in Nextcloud and the effort put into this! 🙇 |
Duplicate Proposal for #16245
(#16251 is pulled on stable 16 ( 16.0.1) )
pulled on MASTER ( $OC_VersionString = '17.0.0 alpha';)
Committer: same person - @gcompagnon @compagnon
/newpassword
/newpassword/email
/newpassword/userid
would provide a dedicated welcome page for new users , letting them enter the same process than Lost Password (new password feature is implemented into LostController)
This URL could be used into a customized Welcome email in a simple way for Business people/sales.
The new user could use that URL to choose his password, and the form could be customized to make user to accept conditions of use.
If the user has never login(is enabled) => this is a First connection
If the user returns, on that URL: this is a Lost Password form
Here is an exception management example: a mailto on the administrator email is enabled