Fix ObjectStoreStorage#file_put_contents #16397
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this method creates creates a stream using php temp stream and passes it to writeStream(). This doesn't work, because the aws uploader cheats and tries to read the original file, which in this case is empty, because
php://temp
cannot be reused. This is why creating new notes in the notes app for example currently fails and only creates an empty note. My fix uses fopen, which directs all writes to a temp file which can be re-opened by the aws uploader with no issues.