Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix references to ownCloud in the federated files sharing app #165

Merged
merged 1 commit into from
Jun 20, 2016

Conversation

schiessle
Copy link
Member

@schiessle schiessle added the 3. to review Waiting for reviews label Jun 20, 2016
@MorrisJobke
Copy link
Member

This is already fixed in #162

@schiessle
Copy link
Member Author

This is already fixed in #162

hm, #162 has less line changes and fixes multiple apps

@schiessle
Copy link
Member Author

@MorrisJobke #162 only fixes the federation app, this is about the federatedfilesharing app.

@@ -2,7 +2,7 @@
<info>
<id>federatedfilesharing</id>
<name>Federated File Sharing</name>
<description>Provide federated file sharing across ownCloud servers</description>
<description>Provide federated file sharing across Nextcloud servers</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we drop the name here completely? Because this should also involve 3rdparty servers in the future (like pydio) ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@MorrisJobke
Copy link
Member

This is already fixed in #162

THis is wrong. Sorry.

That PR looks good 👍

@schiessle schiessle force-pushed the fix-owncloud-references-federated branch from eaf0f2a to 9eaccaf Compare June 20, 2016 12:21
@vincchan
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants