Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable16] Lock SCSS so we only run 1 job at a time #16541

Merged
merged 1 commit into from
Jul 25, 2019
Merged

[stable16] Lock SCSS so we only run 1 job at a time #16541

merged 1 commit into from
Jul 25, 2019

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #15794

@rullzer
Lock SCSS so we only run 1 job at a time
3f5ce65 
This is bit hacky but a start to lock the SCSS compiler properly
Retry during 10s then give up
Properly get error message
Do not clear locks and properly debug scss caching

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 16.0.4 milestone Jul 25, 2019
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 25, 2019
Merged
2 tasks
MorrisJobke
MorrisJobke approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

rullzer
rullzer approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this

@rullzer rullzer added the 4. to release Ready to be released and/or waiting for tests to finish label Jul 25, 2019
@rullzer rullzer merged commit 540168f into stable16 Jul 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport/15794/stable16 branch July 25, 2019 17:40
@rullzer rullzer mentioned this pull request Aug 7, 2019
Merged
2 tasks
@rullzer rullzer mentioned this pull request Sep 12, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@georgehrke georgehrke Awaiting requested review from georgehrke

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug high
Projects
None yet
Milestone
Nextcloud 16.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @MorrisJobke @skjnldsv