Fix login flow form actions #16711
Merged
Fix login flow form actions #16711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Aug 11, 2019
There was a problem hiding this comment.
Makes sense, but failing tests:
There were 2 failures:
131 |
132 | 1) Tests\Core\Controller\ClientFlowLoginControllerTest::testShowAuthPickerPageWithOcsHeader
133 | Failed asserting that two objects are equal.
134 | --- Expected
135 | +++ Actual
136 | @@ @@
137 | + 1 => 'nc://*'
138 |
139 | /drone/src/tests/Core/Controller/ClientFlowLoginControllerTest.php:189
140 |
141 | 2) Tests\Core\Controller\ClientFlowLoginControllerTest::testShowAuthPickerPageWithOauth
142 | Failed asserting that two objects are equal.
143 | --- Expected
144 | +++ Actual
145 | @@ @@
146 | + 1 => 'nc://*'
147 |
148 | /drone/src/tests/Core/Controller/ClientFlowLoginControllerTest.php:248
149
So fun fact. Chrome considers a redirect after submitting a form part of the form actions. Since we redirect to a new protocol (nc://login/). Causing the form submission to work but the redirect failing hard. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
fix/csp/form_actions/loginflow
branch
from
0da7307 to
6dc179e
Compare
|
Right done :) |
skjnldsv
approved these changes
Aug 12, 2019
georgehrke
approved these changes
Aug 12, 2019
georgehrke
added
4. to release
|
@rullzer Backport? |
Nope, form-action was added in 17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So fun fact. Chrome considers a redirect after submitting a form part of
the form actions. Since we redirect to a new protocol (nc://login/).
Causing the form submission to work but the redirect failing hard.
Basically otherwise master is broken with the desktop client (uses chromium) and probably 90% of android (also chrome).
Easiest way to test is probably to try to authenticate your desktop client via the login flow