Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adviced should be advised #16840

Merged
merged 1 commit into from
Aug 23, 2019
Merged

adviced should be advised #16840

merged 1 commit into from
Aug 23, 2019

Conversation

kotp
Copy link
Contributor

@kotp kotp commented Aug 22, 2019

No description provided.

@gary-kim gary-kim added the 3. to review Waiting for reviews label Aug 22, 2019
@gary-kim
Copy link
Member

gary-kim commented Aug 22, 2019

Thank you for your contribution!

You seem to have edited the translation files directly. Those files get updated automatically when you add or change translations in the code. Could you drop all the changes other then the ones to core/js files?

@kotp
Copy link
Contributor Author

kotp commented Aug 22, 2019

Sure, I wondered about that.

Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you dropped your changes to the .js files that were using the translation. Could you put back the changes that were made to the files outside core/l10n and drop the changes to all the files in core/l10n?

Also, could you add a DCO to your commit? The easiest way would be to add the -s flag from the command line. You can also add the following to the bottom of your commit message.

Signed-off-by: Random J Developer <random@developer.example.org>

Signed-off-by: Victor Goff <keeperotphones@gmail.com>
@kotp
Copy link
Contributor Author

kotp commented Aug 23, 2019

I finally realized your desire to make only changes to core/js folder.

@gary-kim
Copy link
Member

Sorry I didn't make that clear. My bad.

@rullzer rullzer added this to the Nextcloud 17 milestone Aug 23, 2019
@rullzer rullzer merged commit 443181f into nextcloud:master Aug 23, 2019
@welcome
Copy link

welcome bot commented Aug 23, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@kotp kotp deleted the adviced_vs_advised branch August 23, 2019 13:39
@rullzer rullzer mentioned this pull request Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants