-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adviced should be advised #16840
adviced should be advised #16840
Conversation
Thank you for your contribution! You seem to have edited the translation files directly. Those files get updated automatically when you add or change translations in the code. Could you drop all the changes other then the ones to |
Sure, I wondered about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you dropped your changes to the .js
files that were using the translation. Could you put back the changes that were made to the files outside core/l10n
and drop the changes to all the files in core/l10n
?
Also, could you add a DCO to your commit? The easiest way would be to add the -s
flag from the command line. You can also add the following to the bottom of your commit message.
Signed-off-by: Random J Developer <random@developer.example.org>
Signed-off-by: Victor Goff <keeperotphones@gmail.com>
I finally realized your desire to make only changes to |
Sorry I didn't make that clear. My bad. |
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
No description provided.