Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the sharing constants publicly available #16845

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Make the sharing constants publicly available #16845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions lib/private/Share/Constants.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,47 @@

namespace OC\Share;

use OCP\Share\IShare;

class Constants {

/**
* @deprecated 17.0.0 - use IShare::TYPE_USER instead
*/
const SHARE_TYPE_USER = 0;
/**
* @deprecated 17.0.0 - use IShare::TYPE_GROUP instead
*/
const SHARE_TYPE_GROUP = 1;
// const SHARE_TYPE_USERGROUP = 2; // Internal type used by DefaultShareProvider
/**
* @deprecated 17.0.0 - use IShare::TYPE_LINK instead
*/
const SHARE_TYPE_LINK = 3;
/**
* @deprecated 17.0.0 - use IShare::TYPE_EMAIL instead
*/
const SHARE_TYPE_EMAIL = 4;
const SHARE_TYPE_CONTACT = 5; // ToDo Check if it is still in use otherwise remove it
/**
* @deprecated 17.0.0 - use IShare::TYPE_REMOTE instead
*/
const SHARE_TYPE_REMOTE = 6;
/**
* @deprecated 17.0.0 - use IShare::TYPE_CIRCLE instead
*/
const SHARE_TYPE_CIRCLE = 7;
/**
* @deprecated 17.0.0 - use IShare::TYPE_GUEST instead
*/
const SHARE_TYPE_GUEST = 8;
/**
* @deprecated 17.0.0 - use IShare::REMOTE_GROUP instead
*/
const SHARE_TYPE_REMOTE_GROUP = 9;
/**
* @deprecated 17.0.0 - use IShare::TYPE_ROOM instead
*/
const SHARE_TYPE_ROOM = 10;
// const SHARE_TYPE_USERROOM = 11; // Internal type used by RoomShareProvider

Expand Down
57 changes: 57 additions & 0 deletions lib/public/Share/IShare.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,63 @@
*/
interface IShare {

/**
* @since 17.0.0
*/
public const TYPE_USER = 0;

/**
* @since 17.0.0
*/
public const TYPE_GROUP = 1;

/**
* @since 17.0.0
*/
public const TYPE_LINK = 3;

/**
* @since 17.0.0
*/
public const TYPE_EMAIL = 4;

/**
* ToDo Check if it is still in use otherwise remove it
* @since 17.0.0
*/
// public const TYPE_CONTACT = 5;

/**
* @since 17.0.0
*/
public const TYPE_REMOTE = 6;

/**
* @since 17.0.0
*/
public const TYPE_CIRCLE = 7;

/**
* @since 17.0.0
*/
public const TYPE_GUEST = 8;

/**
* @since 17.0.0
*/
public const TYPE_REMOTE_GROUP = 9;

/**
* @since 17.0.0
*/
public const TYPE_ROOM = 10;

/**
* Internal type used by RoomShareProvider
* @since 17.0.0
*/
// const TYPE_USERROOM = 11;

/**
* Set the internal id of the share
* It is only allowed to set the internal id of a share once.
Expand Down