-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Symfony's new contract Event class instead of the deprecated one #17085
Use Symfony's new contract Event class instead of the deprecated one #17085
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acceptable IMO.
This now includes the changes from #17084 as |
Which methods are affected? |
Do they use Symfony directly or our abstraction? |
Both functions are still there. |
Also note that it is only for things that use the new event stuff. So talk is not affected right now. |
Pushed another commit. 🤞 this makes our tests happy. Apparently we ran into a form of the fragile base class problem. Yay. |
rebase |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
e982b4d
to
a1ef939
Compare
Leftover from the 4.3 bump at #17049.
Fixes the
deprecation for the new event dispatcher system. In theory this could be a breaking change as apps might have used methods of the old base class, but the likelihood is very low IMO.