Add Symfony inspired typed event dispatcher method #17106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
commented
Sep 11, 2019
| @@ -75,6 +76,10 @@ public function dispatch(string $eventName, | |||
| $this->dispatcher->dispatch($eventName, $event); | |||
| } | |||
|
|
|||
| public function dispatchTyped(Event $event): void { | |||
| $this->dispatch(get_class($event), $event); | |||
There was a problem hiding this comment.
I know I could have passed the event to Symfony and let it do the get_class magic but I would rather have that on our side so we are absolutely sure our expected logic is performed (should they ever change it)
rullzer
approved these changes
Sep 11, 2019
blizzz
approved these changes
Sep 12, 2019
|
That's where all of #14552 started 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
you can