Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to broadcast events to (web) clients #17173

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 17, 2019

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let do this!

core/Command/Broadcast/Test.php Show resolved Hide resolved
@skjnldsv
Copy link
Member

Any news? :)

@ChristophWurst ChristophWurst force-pushed the feature/event-broadcasting branch 2 times, most recently from 98f6bfd to 3cb2c17 Compare October 22, 2019 09:10
@ChristophWurst
Copy link
Member Author

Any news? :)

Time to review :)

@nickvergessen
Copy link
Member

Didn't test, but do you know if this works with http2?
The long polling we currently use in Talk breaks the Nextcloud on http2, because the connection is always kept open.

@ChristophWurst
Copy link
Member Author

I only tested on nginx with http2 and could not see any problems with that. And the fallback does not use long polling but just returns immediately. I think long polling is also problematic in Nextcloud if you use sqlite as one request can block all others do to the single user restriction.

@ChristophWurst
Copy link
Member Author

Didn't test, but do you know if this works with http2?
The long polling we currently use in Talk breaks the Nextcloud on http2, because the connection is always kept open.

Turned out this was caused by a misconfigured apache.

Review time :)

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Oct 28, 2019

@daita @juliushaertl @nickvergessen @skjnldsv mind giving this a review? Then I can continue with the part in Push :)

The sooner we get this in the more time there is to experiment and iterate on the API design if necessary.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@rullzer rullzer merged commit 70500e2 into master Oct 28, 2019
@rullzer rullzer deleted the feature/event-broadcasting branch October 28, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants