-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to broadcast events to (web) clients #17173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let do this!
Any news? :) |
98f6bfd
to
3cb2c17
Compare
Time to review :) |
Didn't test, but do you know if this works with http2? |
I only tested on nginx with http2 and could not see any problems with that. And the fallback does not use long polling but just returns immediately. I think long polling is also problematic in Nextcloud if you use sqlite as one request can block all others do to the single user restriction. |
3cb2c17
to
abd14f6
Compare
Turned out this was caused by a misconfigured apache. Review time :) |
@daita @juliushaertl @nickvergessen @skjnldsv mind giving this a review? Then I can continue with the part in Push :) The sooner we get this in the more time there is to experiment and iterate on the API design if necessary. |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
abd14f6
to
d180a98
Compare
Best reviewed together with nextcloud/push#27
Interesting reads on the topic
https://symfony.com/blog/symfony-gets-real-time-push-capabilities
https://github.com/dunglas/mercure
https://developer.mozilla.org/en-US/docs/Web/API/Server-sent_events
https://laravel.com/docs/5.7/broadcasting#introduction