Add file action to move files and folders #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @rullzer and @MorrisJobke to be potential reviewers. |
|
|
Tested and works 👍 @jancborchardt we need an icon for the move action - currently it's the pencil |
|
Very cool! Here you go with a more fitting icon, the »external« icon looks nice and I’m not sure if it warrants creating a different one: 👍 from my side |
|
Btw @icewind1991 can you change the filepicker title to »Move |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will look into improving the file picker in a seperate PR for some beter ux