-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload time and Creation time #17765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Seems to work. Lets get this in now and discuss the rest separately. It already got big enough IMO.
2fca816
to
4f85ec0
Compare
Can we schedule this also for 18, if possible? @rullzer |
@tobiasKaminsky sure we can expose it. But right now it doesn't do anything so there is no use. It is an empty column. Just adding some value there doesn't help as it would need to duplicate the propagation logic as well because other wise you'd still need to check all files separately and then you can just do what you do now. |
Damn…I only read the first part with "exposing"… |
4f85ec0
to
7282568
Compare
this make the type hints work properly with querybuilder subclasses Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
67bf2fc
to
4b31862
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
1cb346d
to
f272499
Compare
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@icewind1991 @rullzer I have create a search dav as :
but do not works (errro 400) ... It's a my error ? |
upload time needs to be a unix timestamp as far as I understand this, so e.g. 1591767801. |
@tobiasKaminsky do not change, the error 400 continues ... |
@icewind1991 please, the new properties works with the searchrequest ? |
This adds the logic to use the
filecache_extended
table, it allows storing and retrievingmetadata_etag
,creation_time
andupload_time
in the filecache, howevermetadata_etag
is not exposed trough the public api for now and any logic for tracking it is left for future work.PROPFIND
or as a header during upload)We might want to add some automated logic for setting ctime in the future.
Now the
filecache_extended
table is getting used, we should think of any fields we might want to store in the future (even if they remain unused for a while) before we release 18