Make timeout a optional parameter

[kesselb]

Fix #17846

otherwise you cannot create a new smb storage via gui

[kesselb]

/backport to stable17

[rullzer]

whoops

[backportbot-nextcloud]

backport to stable17 in #17925

[kesselb]

/backport to stable16

[backportbot-nextcloud]

backport to stable16 in #17929

[henrikx]

I thought I was going crazy and I've been searching for hours. And I was so confused when adding the storage via occ worked fine.
Turns out everything in my setup was correct and it was this all along.

Got reply message "Unsatisfied backend parameters" from webserver when trying to update anything related to external storage via GUI.

[Golffies]

Applied the fix described in #17846 on a 17.0.1 stable NC. Did not solve the issue for me. From the web GUI:

Using backend: php-smbclient

Error while loading share content.

Icewind\SMB\Exception\ConnectionRefusedException:

    /var/www/html/nc1/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php - line 62:

    Icewind\SMB\Exception\Exception::fromMap({ 1: "Icewin ... "}, 111, null)

    /var/www/html/nc1/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php - line 74:

    Icewind\SMB\Native\NativeState->handleError(null)

    /var/www/html/nc1/apps/files_external/3rdparty/icewind/smb/src/Native/NativeState.php - line 105:

    Icewind\SMB\Native\NativeState->testResult(false, "smb:///")

    /var/www/html/nc1/apps/files_external/3rdparty/icewind/smb/src/Native/NativeShare.php - line 92:

    Icewind\SMB\Native\NativeState->opendir("smb:///")

    /var/www/html/nc1/apps/smb_test/lib/Controller/SmbController.php - line 95:

    Icewind\SMB\Native\NativeShare->dir(null)

    /var/www/html/nc1/lib/private/AppFramework/Http/Dispatcher.php - line 170:

    OCA\SMBTest\Controller\SmbController->dir(null, null, null, null, Icewind\SMB\ ... {}, null)

    /var/www/html/nc1/lib/private/AppFramework/Http/Dispatcher.php - line 99:

    OC\AppFramework\Http\Dispatcher->executeController(OCA\SMBTest\ ... {}, "dir")

    /var/www/html/nc1/lib/private/AppFramework/App.php - line 126:

    OC\AppFramework\Http\Dispatcher->dispatch(OCA\SMBTest\ ... {}, "dir")

    /var/www/html/nc1/lib/private/AppFramework/Routing/RouteActionHandler.php - line 47:

    OC\AppFramework\App::main("OCA\\SMBTes ... r", "dir", OC\AppFramew ... {}, { _route: "smb_test.smb.dir"})

    OC\AppFramework\Routing\RouteActionHandler->__invoke({ _route: "smb_test.smb.dir"})

    /var/www/html/nc1/lib/private/Route/Router.php - line 297:

    call_user_func(OC\AppFramew ... {}, { _route: "smb_test.smb.dir"})

    /var/www/html/nc1/lib/base.php - line 1000:

    OC\Route\Router->match("/apps/smb_test/dir")

    /var/www/html/nc1/index.php - line 42:

    OC::handleRequest()