Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow file entity to provide the internal URL #18162

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Nov 29, 2019

for instance being used in nextcloud/spreed#2487

try {
//return $this->urlGenerator->getAbsoluteURL('/f/' . $this->getNode()->getId());
return $this->urlGenerator->linkToRouteAbsolute('files.viewcontroller.showFile', ['fileid' => $this->getNode()->getId()]);
return $this->urlGenerator->getBaseUrl() . '/f/' . $this->getNode()->getId();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two returns?

@nickvergessen nickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 4, 2019
This was referenced Dec 11, 2019
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the enh/noid/url-fileentity branch from cf9b294 to f8394e3 Compare December 13, 2019 11:33
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 13, 2019
@blizzz blizzz requested a review from nickvergessen December 13, 2019 11:34
@rullzer rullzer mentioned this pull request Dec 19, 2019
18 tasks
@blizzz blizzz merged commit 5a986f0 into master Dec 19, 2019
@blizzz blizzz deleted the enh/noid/url-fileentity branch December 19, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants