Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert various columns in oc_mounts to bigint #18299

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Convert various columns in oc_mounts to bigint #18299

merged 1 commit into from
Dec 9, 2019

Conversation

georgehrke
Copy link
Member

Fixes error messages like:

'SQLSTATE[22003]: Numeric value out of range: 1264 Out of range value for column 'root_id' at row 1"'.

@georgehrke georgehrke added the 3. to review Waiting for reviews label Dec 9, 2019
@georgehrke
Copy link
Member Author

/backport to stable17

@georgehrke
Copy link
Member Author

/backport to stable16

@georgehrke
Copy link
Member Author

/backport to stable15

@rullzer
Copy link
Member

rullzer commented Dec 9, 2019

Please also adjust the checks in the setupchecks so people get notified.

@georgehrke
Convert various columns in oc_mounts to bigint
699f3a6 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/noid/filecache_bigint_mounts branch from e8917c8 to 699f3a6 Compare December 9, 2019 13:13
@georgehrke
Copy link
Member Author

Good catch. Fixed

ChristophWurst
ChristophWurst approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@nickvergessen
Copy link
Member

Should also adjust the migration file which creates this table, so new installations are fixed already, and you dont get a warning right after install

@georgehrke
Copy link
Member Author

Should also adjust the migration file which creates this table, so new installations are fixed already, and you dont get a warning right after install

Sure, let's do that in a follow up PR? Then i will also tackle the ones from #18004

@rullzer rullzer added this to the Nextcloud 18 milestone Dec 9, 2019
@rullzer rullzer merged commit 6ddb789 into master Dec 9, 2019
@rullzer rullzer deleted the bugfix/noid/filecache_bigint_mounts branch December 9, 2019 20:38
@rullzer
Copy link
Member

rullzer commented Dec 9, 2019

@georgehrke done ;)

Could you tackle the followup?

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 9, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable17 in #18307

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 9, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable16 in #18309

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 9, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #18310

@rullzer rullzer mentioned this pull request Dec 11, 2019
Merged
43 tasks
@kesselb kesselb mentioned this pull request Jan 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@georgehrke @rullzer @nickvergessen @ChristophWurst