Sort favorite files first

[ryanwr]

Shows the favorited files first in the file list, Issue #1802

I'd appreciate feedback on this!

[mention-bot]

@ryanwr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @icewind1991 and @butonic to be potential reviewers.

[MorrisJobke]

cc @nickvergessen

[nickvergessen]

Tested and works 👍

[MorrisJobke]

Awesome! I tested it with a directory with many files (where pagination is used) and it works fine 👍

[MorrisJobke]

@ryanwr There is only the sign-off missing. See https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work for more details about it. To fix this you could do git commit --amend -s then the sign-off message is added and you only need to force push (because you have changed an existing commit) via git push --force origin feature-sort-favorite.

Thanks a lot for your contribution 😃 Feel free to join our IRC channel #nextcloud-dev on freenode and check out other starter issues: https://github.com/nextcloud/server/labels/starter%20issue

[ryanwr]

Thanks!

@MorrisJobke It should be signed off now! 😄

[codecov-io]

Current coverage is 57.28% (diff: 100%)

No coverage report found for master at cfae91a.

Powered by Codecov. Last update cfae91a...3e96f33

[ryanwr]

Looks like drone ci failed, doesn't look related to my changes though

[rullzer]

Agreed looks unrelated.
Lets merge this. But we probabaly need js tests for this behaviour. Just so it doesn't break.

[jancborchardt]

@ryanwr awesome work! :) Sometimes when favoriting a file further down it seems to jump up a row.
Did you intend for it to jump up all the way, or nothing to happen until next reload / navigation / sort change?

[nickvergessen]

There is no jumping here

[ryanwr]

There shouldn't be any jumping, it shouldnt change anything until it's sorted again by reloading or resorting

[jancborchardt]

Ok, maybe a problem with my dev setup.