Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow validity checks #18612

Merged
merged 5 commits into from
Jan 2, 2020
Merged

Workflow validity checks #18612

merged 5 commits into from
Jan 2, 2020
+60 −55

Conversation

juliusknorr
Copy link
Member

  • Improve propagation of check validity to the rule
  • Remove unused style loading
  • Load polyfill
  • Limit password confirmation to admin rules and rule deletion

@juliusknorr juliusknorr added this to the Nextcloud 18 milestone Dec 30, 2019
blizzz
blizzz approved these changes Dec 30, 2019
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@juliusknorr
Remove style loading of non-existing file
75b217c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Refactor validity propagation
7320de1 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Load polyfill in workflow engine
3203e81 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Only ask for password when updating admin rules
df54bb9 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Bump bundles
492ca95 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

Rebased

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 2, 2020
@rullzer rullzer mentioned this pull request Jan 2, 2020
Merged
13 tasks
@rullzer rullzer merged commit dbbe687 into master Jan 2, 2020
@rullzer rullzer deleted the bugfix/flow-style branch January 2, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz

@skjnldsv skjnldsv

@rullzer rullzer

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: workflows
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juliusknorr @blizzz @skjnldsv @rullzer