Don't show link shares in sidebar if disabled #18672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
added
enhancement
3. to review
rullzer
requested review from
ChristophWurst,
blizzz,
juliusknorr and
skjnldsv
4 tasks
|
I mean, we show the existing ones. If it was allowed before, but disabled after, it make sense to still show them. How would you remove them then? Currently we prevent creating new ones :) |
No we should not show them. Since they won't work anyways. |
Ok then :) |
skjnldsv
approved these changes
Jan 6, 2020
Fixes #17799 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
fix/17799/if_disabled_dont_show_link_shares
branch
from
2ce1b88 to
d4ce8c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17799
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl