Remove notify recipient function #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @DeepDiver1975 and @schiessle to be potential reviewers. |
|
Delete all the code 👍 |
|
LGTM |
|
Should we also delete such configs with a repairstep? |
|
@nickvergessen fair enough. I'll take of that later today. |
@rullzer Is this already done? |
|
It's done in #1978 |
|
See the problem solves itself :) |
MorrisJobke
added a commit
that referenced
this pull request
Nov 29, 2016
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
eppfel
pushed a commit
that referenced
this pull request
Nov 30, 2016
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
blizzz
pushed a commit
that referenced
this pull request
Dec 7, 2016
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is not needed as recipients can decide themselfs if they want to get a notification.
CC: @schiessle @nickvergessen @MorrisJobke @LukasReschke