Move lately used tags to the top

[nickvergessen]

• Add a tag to a file
• Open the sidebar of another file
• See the tag you just assigned being sorted first.

Stores up to 10 tags atm
Ref 2nd checkbox of #1465

[mention-bot]

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81 to be a potential reviewer.

[nickvergessen]

Not sure why this file is in core, instead of systemtags app.

But maybe the sorting should be moved to dav then aswell

[codecov-io]

Current coverage is 57.78% (diff: 0.00%)

Merging #1934 into master will decrease coverage by 0.02%

@@             master      #1934   diff @@
==========================================
  Files          1094       1096     +2   
  Lines         62800      62825    +25   
  Methods        6996       6999     +3   
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          36303      36303          
- Misses        26497      26522    +25   
  Partials          0          0          

Diff Coverage	File Path
0%	new ...pps/systemtags/lib/Controller/LastUsedController.php
0%	new apps/systemtags/appinfo/routes.php
0%	apps/systemtags/lib/Activity/Listener.php
•••••••••• 100%	.../lib/SystemTag/SystemTagsObjectMappingCollection.php

Powered by Codecov. Last update 1857e50...8e5651c

[ChristophWurst]

This only works if I reload the page after assigning the first tag. It looks like the ajax call to get the last used tags is only performed once.

[nickvergessen]

Yes, it's only performed once, afterwards the local instance should keep it updated, or I did something wrong.

[ChristophWurst]

afterwards the local instance should keep it updated

That does not work. I tested it with FF and without reloading the lastly assigned tag (I created a new one) was sorted as last tag in the list of suggested tags.

[nickvergessen]

I created a new one

little important detail, will have a look

[nickvergessen]

Fixed

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

@nextcloud/javascript @icewind1991 @rullzer @LukasReschke Please review

[rullzer]

No tests?

[nickvergessen]

Feel free to, I'm not good in JS tests

[jancborchardt]

Awesome idea @nickvergessen!

[MorrisJobke]

@rullzer Mind to review?

[MorrisJobke]

@LukasReschke @ChristophWurst @rullzer Review?

[ChristophWurst]

👍 now my test case worked 😉

[ChristophWurst]

Btw. should we have a tooltip on the trash icon in the tag list? I had never used tags before and I wasn't sure whether the trash icon (only shown if one hits the pencil before) unassigns a tag or deletes it (which would also effect other files/folders).

[MorrisJobke]

Btw. should we have a tooltip on the trash icon in the tag list? I had never used tags before and I wasn't sure whether the trash icon (only shown if one hits the pencil before) unassigns a tag or deletes it (which would also effect other files/folders).

cc @nickvergessen @jancborchardt

[nickvergessen]

Deleting should be removed altogether.
There is also an issue for it.