Revive the "send email to new users" toggle for the user form #19664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
enhancement
2. developing
ChristophWurst
force-pushed
the
feature/revive-send-welcome-email-toggle
branch
from
5c09e1b to
1606636
Compare
ChristophWurst
added
3. to review
skjnldsv
reviewed
Feb 27, 2020
ChristophWurst
force-pushed
the
feature/revive-send-welcome-email-toggle
branch
from
1606636 to
8ab9daf
Compare
rullzer
requested changes
Feb 28, 2020
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
feature/revive-send-welcome-email-toggle
branch
from
8ab9daf to
d47daef
Compare
skjnldsv
approved these changes
Feb 28, 2020
skjnldsv
added
4. to release
|
/backport to stable17 |
|
/backport to stable18 |
|
The backport to stable17 failed. Please do this backport manually. |
|
The backport to stable18 failed. Please do this backport manually. |
This was referenced Feb 28, 2020
| * | ||
| * @return JSONResponse | ||
| */ | ||
| public function setPreference(string $key, string $value): JSONResponse { |
There was a problem hiding this comment.
We have an ocs api to set app configs. It even comes with a nice JS api for it
|
/backport to stable-16 |
|
/backport to stable16 |
|
The backport to stable16 failed. Please do this backport manually. |
|
/backport to stable16 |
|
The backport to stable16 failed. Please do this backport manually. |
|
We don't need this in 16. |
|
ok :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11172
This is the minimalist version, so we can easily backport it. Someone can later integrate this better into the new form.
Todo