Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkbox left margin glitch #1971

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Fix checkbox left margin glitch #1971

merged 1 commit into from
Nov 2, 2016

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 1, 2016 •
edited by MorrisJobke
Loading

Fix checkbox left margin glitch

Fix #1782
@jancborchardt

@mention-bot
Copy link

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @juliushaertl, @LukasReschke and @schiessle to be potential reviewers.

@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: theming labels Nov 1, 2016
@skjnldsv skjnldsv self-assigned this Nov 1, 2016
@LukasReschke
Copy link
Member

Also requires adjusting the unit tests :)

@LukasReschke LukasReschke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 1, 2016
@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 1, 2016

@LukasReschke Forgot :)

@LukasReschke LukasReschke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 1, 2016
@rullzer rullzer force-pushed the fix-checkbox-glitch branch from fb0884e to ad92a90 Compare November 2, 2016 07:42
@MorrisJobke MorrisJobke changed the title Fix #1782 Fix checkbox left margin glitch Nov 2, 2016
@skjnldsv @MorrisJobke
Fix #1782
bc5268b 
Fix checkbox left margin glitch
Fix tests
fix unit tests

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member

I fixed the remaining unit tests and signed it off

@MorrisJobke
Copy link
Member

Tested and works 👍

@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Nov 2, 2016
@jancborchardt
Copy link
Member

@skjnldsv please ideally add a before/after screenshot or reference the issue being fixed in the summary so it’s linked. :)

@MorrisJobke
Copy link
Member

@skjnldsv please ideally add a before/after screenshot or reference the issue being fixed in the summary so it’s linked. :)

There is the reference in the very first comment ;) Just check it out:

bildschirmfoto 2016-11-02 um 15 23 22

@jancborchardt
Copy link
Member

@MorrisJobke ty! Just checked the comments and file changes, didn’t catch that

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 2, 2016

😆

@rullzer
Copy link
Member

rullzer commented Nov 2, 2016

LGTM

@rullzer rullzer merged commit 3bdec28 into master Nov 2, 2016
@rullzer rullzer deleted the fix-checkbox-glitch branch November 2, 2016 19:02
@jancborchardt jancborchardt mentioned this pull request Nov 14, 2016
Closed
@juliusknorr juliusknorr mentioned this pull request Nov 16, 2016
Merged
@snyk-bot snyk-bot mentioned this pull request May 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: theming
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging this pull request may close these issues.
6 participants
@skjnldsv @mention-bot @LukasReschke @MorrisJobke @jancborchardt @rullzer