Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for "languageCodes.php" #1988

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Conversation

LukasReschke
Copy link
Member

Arguably not the most awesome test but increases coverage and is an easy gain.

Signed-off-by: Lukas Reschke lukas@statuscode.ch

Arguably not the most awesome test but increases coverage and is an easy gain.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
@LukasReschke LukasReschke added the 3. to review Waiting for reviews label Nov 2, 2016
@LukasReschke LukasReschke added this to the Nextcloud 11.0 milestone Nov 2, 2016
@LukasReschke
Copy link
Member Author

@rullzer
Copy link
Member

rullzer commented Nov 2, 2016

Fair enogh... 👍

@LukasReschke LukasReschke changed the title Add test for "languageCodesTest.php" Add test for "languageCodes.php" Nov 2, 2016
@MorrisJobke
Copy link
Member

But at least it makes sense to have them 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 2, 2016
@MorrisJobke MorrisJobke merged commit 178d7f5 into master Nov 2, 2016
@MorrisJobke MorrisJobke deleted the silly-but-effective-test branch November 2, 2016 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants