Improved vcard photo handling #19901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
commented
Mar 12, 2020
georgehrke
requested changes
Mar 12, 2020
skjnldsv
approved these changes
Apr 1, 2020
|
CI says nope |
nickvergessen
force-pushed
the
bugfix/noid/vcard-photo-handling
branch
from
ff0b444 to
fabec4c
Compare
|
@georgehrke final +1? |
georgehrke
requested changes
Apr 2, 2020
|
sooooo? |
|
I'm currently unsure about @georgehrke s comments. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
georgehrke
force-pushed
the
bugfix/noid/vcard-photo-handling
branch
from
fabec4c to
fe4527a
Compare
|
Good to go now? |
|
👍 from my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.