Properly respect hide download on sharebymail #19914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
nickvergessen,
wiswedel,
juliusknorr,
kesselb and
danxuliu
|
@skjnldsv yeah I think so as well. But that would mean unlinking the link provider from the default one |
nickvergessen
approved these changes
Mar 12, 2020
juliusknorr
approved these changes
Mar 13, 2020
So, follow up? :) |
skjnldsv
approved these changes
Mar 13, 2020
fixes #19484 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
fix/19484/sharebymail_hidedownload
branch
from
b004d2e to
84a148a
Compare
georgehrke
approved these changes
Mar 13, 2020
wiswedel
approved these changes
Mar 13, 2020
|
/backport to stable18 |
|
backport to stable18 in #19921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19484
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl