Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17] Handle long dav property paths by hashing them #20034

Merged
merged 8 commits into from
Mar 24, 2020
Merged

[17] Handle long dav property paths by hashing them #20034

merged 8 commits into from
Mar 24, 2020

Conversation

icewind1991
Copy link
Member

Backport of #19242

@icewind1991
merge the two almost identical custom property backends
a5164ee 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test custom properties backend against real database
594873d 
test behaviour not implementation

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
remove unused code
28fed26 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
handle long property paths to hasing paths >250 chars
0c49273 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
use INode instead of Node for custom properties
61f95a1 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
remove the detour trough node and work with path directly
37150d0 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix tests
d108833 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
rebuild autoloader
12d0b9c 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 19, 2020
@icewind1991 icewind1991 added this to the Nextcloud 17.0.5 milestone Mar 19, 2020
@icewind1991 icewind1991 requested a review from rullzer March 19, 2020 14:58
@rullzer rullzer modified the milestones: Nextcloud 17.0.5, Nextcloud 17.0.6 Mar 23, 2020
nickvergessen
nickvergessen approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

rullzer
rullzer approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer rullzer merged commit cf80eeb into stable17 Mar 24, 2020
@rullzer rullzer deleted the dav-long-properties-17 branch March 24, 2020 19:53
@rullzer rullzer mentioned this pull request Apr 13, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 17.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @rullzer @nickvergessen