Removed else statement preventing Success message from displaying cau… #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing bug #1875 Signed-off-by: Henry Mohn <hmohniii@gmail.com>
|
@henrymohn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @Kondou-ger and @icewind1991 to be potential reviewers. |
Current coverage is 57.78% (diff: 100%)@@ master #2021 diff @@
==========================================
Files 1094 1094
Lines 62797 62797
Methods 6994 6994
Messages 0 0
Branches 0 0
==========================================
- Hits 36291 36290 -1
- Misses 26506 26507 +1
Partials 0 0
|
|
Welcome and thank you for your pull request! 😃 Code looks good 👍 |
|
Tested and works 👍 |
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed else statement preventing "Saved" message from displaying causing bug #1875 . Else statement is not needed since password-err-msg should show in both success and error situations.
Signed-off-by: Henry Mohn hmohniii@gmail.com