Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list of multiple properties #20529

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Update list of multiple properties #20529

merged 1 commit into from
Apr 17, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 17, 2020 •
edited
Loading 

in_array($property->name, ['URL', 'GEO', 'CLOUD', 'ADR', 'EMAIL', 'IMPP', 'TEL', 'X-SOCIALPROFILE', 'RELATED', 'LANG', 'X-ADDRESSBOOKSERVER-MEMBER'])

I really hate this!
I'm curious to see if we don't have a valid list somewhere which we wouldn't have to manually update 🤦

@skjnldsv skjnldsv self-assigned this Apr 17, 2020
@skjnldsv skjnldsv added this to the Nextcloud 19 milestone Apr 17, 2020
@skjnldsv
Copy link
Member Author

/backport to stable18

@skjnldsv
Copy link
Member Author

/backport to stable17

@nickvergessen nickvergessen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 17, 2020
@nickvergessen

This comment has been minimized.

Sign in to view
@skjnldsv skjnldsv force-pushed the fix/Card-multiple branch from 9a6d9ff to 238b84c Compare April 17, 2020 07:28
@skjnldsv
Copy link
Member Author

skjnldsv commented Apr 17, 2020 •
edited
Loading

Tests pushed with additional testing array :)
Please review!

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 17, 2020
@skjnldsv skjnldsv mentioned this pull request Apr 17, 2020
Closed
@skjnldsv
Update list of multiple properties
2954132 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/Card-multiple branch from 238b84c to 2954132 Compare April 17, 2020 07:38
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 17, 2020
@skjnldsv skjnldsv merged commit 7c4b7e9 into master Apr 17, 2020
@skjnldsv skjnldsv deleted the fix/Card-multiple branch April 17, 2020 08:39
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 17, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable18 in #20531

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 17, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable17 in #20532

@rullzer rullzer mentioned this pull request Apr 17, 2020
Merged
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@georgehrke georgehrke Awaiting requested review from georgehrke

@rullzer rullzer Awaiting requested review from rullzer

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dav
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @nickvergessen @ChristophWurst