do not run paged results against ldap_read ops on PHP7.3+ #20536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
rullzer,
MorrisJobke,
ChristophWurst,
juliusknorr,
kesselb and
skjnldsv
blizzz
added
4. to release
- previously it was needed as the PHP LDAP handling of paged results was
strange
- but now the read operation would fail, e.g. with extra home dir attribute
set ("Home dir attribute can't be read from LDAP for uid: foobar"
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/noid/ldap-73api-read-wo-pagedresults
branch
from
c62907e to
75c686d
Compare
juliusknorr
approved these changes
Apr 21, 2020
|
@blizzz What about backports? |
New code, affects 19 only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strange
set ("Home dir attribute can't be read from LDAP for uid: foobar"
That's also how to reproduce it. With PHP 7.3, set an home dir attribute in LDAP's advanced tab and go to users page. It'll fail without this change.