Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix share expiration date not shown #20538

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Fix share expiration date not shown #20538

merged 1 commit into from
Apr 30, 2020

Conversation

gary-kim
Copy link
Member

@gary-kim gary-kim commented Apr 17, 2020 •
edited
Loading

Fixes #20520

Needs to be built with nextcloud-libraries/nextcloud-vue#1029 No longer necessary.

Signed-off-by: Gary Kim gary@garykim.dev

@gary-kim gary-kim added bug 3. to review Waiting for reviews labels Apr 17, 2020
@gary-kim gary-kim added this to the Nextcloud 19 milestone Apr 17, 2020
@gary-kim gary-kim force-pushed the fix/20520/share-expire branch from 7f363db to dc436ab Compare April 17, 2020 14:17
skjnldsv
skjnldsv approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good :D

@gary-kim gary-kim force-pushed the fix/20520/share-expire branch from dc436ab to 728781e Compare April 17, 2020 15:49
@gary-kim
Copy link
Member Author

gary-kim commented Apr 17, 2020 •
edited
Loading

There's also a seperate issue where the not-before and not-after don't do anything in vue2-datepicker. It wants a disabled-date function instead. Should we implement that in @nextcloud/vue so other apps can reuse it or here?

@skjnldsv
Copy link
Member

There's also a seperate issue where the not-before and not-after don't do anything in vue2-datepicker. It wants a disabled-date function instead. Should we implement that in @nextcloud/vue so other apps can reuse it or here?

I guess we should adapt this here :)
We shouldn't be more complicated than the original library. W''re just wrapping our styling mostly :)

So let's upgrade to disabled-date here ?

@rullzer rullzer mentioned this pull request Apr 18, 2020
Merged
55 tasks
@skjnldsv skjnldsv mentioned this pull request Apr 22, 2020
Merged
@rullzer rullzer mentioned this pull request Apr 23, 2020
Merged
11 tasks
@ChristophWurst
Copy link
Member

So let's upgrade to disabled-date here ?

@gary-kim @skjnldsv is this ok to merge or are there any missing changes?

@gary-kim
Copy link
Member Author

So let's upgrade to disabled-date here ?

@gary-kim @skjnldsv is this ok to merge or are there any missing changes?

I'd say that's a separate issue that's better addressed in another PR.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 30, 2020
@skjnldsv
Copy link
Member

Please rebase :)

@gary-kim gary-kim force-pushed the fix/20520/share-expire branch from 728781e to 8c71659 Compare April 30, 2020 08:10
@gary-kim
Copy link
Member Author

Please rebase :)

Done!

@gary-kim
Fix share expiration date not shown
02b5ded 
Signed-off-by: Gary Kim <gary@garykim.dev>
@gary-kim gary-kim force-pushed the fix/20520/share-expire branch from 8c71659 to 02b5ded Compare April 30, 2020 14:36
@rullzer rullzer mentioned this pull request Apr 30, 2020
Merged
2 tasks
@rullzer rullzer merged commit b2b8be8 into master Apr 30, 2020
@rullzer rullzer deleted the fix/20520/share-expire branch April 30, 2020 18:55
@gary-kim gary-kim mentioned this pull request May 1, 2020
Merged
@skjnldsv
Copy link
Member

skjnldsv commented May 1, 2020

Wait, this actually broke things 🙈
value-type="format" means they'll use the data provided by "format".
But we don't provide any format 🤷

@skjnldsv
Copy link
Member

skjnldsv commented May 1, 2020

AH it's fine, format has default 'YYYY-MM-DD'
Let me see what broke then, might not be this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.

Share expiration date not shown
4 participants
@gary-kim @skjnldsv @ChristophWurst @rullzer