-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable18] dont show remote and email options if we have an exact match for local user email #20574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
CI fails:
|
doesn't work for me with 18.0.4. Sharee search field keeps spinning forever, even if matching email address is entered. Now not even guest invitation gets offered. |
in 19 beta however it works. But we need the backport to work as well. |
This pr is for 18.0.5 🤔 |
So what now? Can this be patched into an 18.0.3 or 18.0.4, or are there other dependencies coming with 18.0.5 only? Customer is waiting. |
@icewind1991 ? |
ce4fcb7
to
1cf1bc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI fails
…l user email Signed-off-by: Robin Appelman <robin@icewind.nl>
1cf1bc9
to
e26c055
Compare
Ci is happy |
backport of #16035
Fixes #20359