Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] Do not filter id matching userId on non-user-share shares #20842

Merged
merged 1 commit into from
Jul 16, 2020
Merged

[stable18] Do not filter id matching userId on non-user-share shares #20842

merged 1 commit into from
Jul 16, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 6, 2020 •
edited by skjnldsv
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #20832

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.5 milestone May 6, 2020
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label May 6, 2020
@skjnldsv skjnldsv force-pushed the backport/20832/stable18 branch from 23f9a59 to f22a12e Compare May 6, 2020 15:52
skjnldsv
skjnldsv approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and pushed
Waiting for compilebot

@skjnldsv
Copy link
Member

skjnldsv commented May 6, 2020

/compile amend /

@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the backport/20832/stable18 branch from f22a12e to 05b2c33 Compare May 6, 2020 16:12
@rullzer rullzer mentioned this pull request May 21, 2020
Merged
5 tasks
@ChristophWurst ChristophWurst force-pushed the backport/20832/stable18 branch 2 times, most recently from 5453934 to 9e9ad22 Compare May 28, 2020 07:25
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 28, 2020
@MorrisJobke
Copy link
Member

needs to wait for 18.0.6

@rullzer rullzer mentioned this pull request Jun 8, 2020
Merged
1 task
@MorrisJobke
Copy link
Member

@skjnldsv Mind to rebuild?

@rullzer rullzer mentioned this pull request Jul 6, 2020
Merged
5 tasks
@skjnldsv skjnldsv force-pushed the backport/20832/stable18 branch from 9e9ad22 to a538536 Compare July 14, 2020 14:50
@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv @npmbuildbot
Do not filter id matching userId on non-user-share shares
c966656 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the backport/20832/stable18 branch from a538536 to c966656 Compare July 14, 2020 15:03
@rullzer rullzer merged commit b2cd82d into stable18 Jul 16, 2020
@rullzer rullzer deleted the backport/20832/stable18 branch July 16, 2020 18:48
@rullzer rullzer mentioned this pull request Aug 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke requested changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: sharing high regression
Projects
None yet
Milestone
Nextcloud 18.0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @MorrisJobke @rullzer @ChristophWurst