Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move humanFileSize and OC.getCanonicalLocale to npm packages #21225

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Move humanFileSize and OC.getCanonicalLocale to npm packages #21225

merged 1 commit into from
Jun 5, 2020

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews technical debt pending documentation This pull request needs an associated documentation update labels Jun 4, 2020
@ChristophWurst ChristophWurst added this to the Nextcloud 20 milestone Jun 4, 2020
@ChristophWurst ChristophWurst self-assigned this Jun 4, 2020
rullzer
rullzer requested changes Jun 4, 2020
View reviewed changes
core/src/OC/l10n.js Outdated Show resolved Hide resolved
rullzer
rullzer approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ChristophWurst ChristophWurst force-pushed the techdebt/humanfilesize-getcanonicallocale-package branch from babe7d6 to d48b091 Compare June 4, 2020 09:39
@ChristophWurst
Copy link
Member Author

/compile amend /

@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 4, 2020
@rullzer
Copy link
Member

rullzer commented Jun 5, 2020

Conflicts....

@ChristophWurst
Move humanFileSize and OC.getCanonicalLocale to npm packages
eaf4724 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the techdebt/humanfilesize-getcanonicallocale-package branch from d48b091 to eaf4724 Compare June 5, 2020 06:49
@ChristophWurst
Copy link
Member Author

Rebased

@ChristophWurst
Copy link
Member Author

CI was happy btw (esp jsunit), so this should be good to merge

@rullzer rullzer merged commit 81f83d3 into master Jun 5, 2020
@rullzer rullzer deleted the techdebt/humanfilesize-getcanonicallocale-package branch June 5, 2020 07:02
This was referenced Oct 6, 2020
Merged
Merged
@ChristophWurst
Copy link
Member Author

Docs at nextcloud/documentation#5185

@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@georgehrke georgehrke georgehrke approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@caugner caugner Awaiting requested review from caugner

@ahstro ahstro Awaiting requested review from ahstro

@stefan-niedermann stefan-niedermann Awaiting requested review from stefan-niedermann

@korelstar korelstar Awaiting requested review from korelstar

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @rullzer @georgehrke @juliushaertl