Add Editing for Link Share Labels

[gary-kim]

Closes #21265

Still a work in progress.
Will need to be added separately to the mobile and desktop apps.

This is more just an idea at the moment so feel free to comment on what you think about the idea of having a "note to self" for shares. The idea is to have a place to put notes to yourself about the share. Found the need to do this often for marking down which link is shared where.

The goal changed slightly. A entire note to self section is overkill so we are now giving the user the ability to edit the label for link shares.

[gary-kim]

Umm... confused. So, it passed but it also didn't?

[jancborchardt]

I’m not sure we should right away go with such a detailed note. One thing we should for sure already do is to have a subline for the "Copy link" which shows the details about chosen options, like:

Share link
Editable, password protected

or

Share link
Read-only, expires in 5 days

This already helps a lot to know what these links do and are for, without any further interaction needed.

[gary-kim]

I was implementing a solution like this because, for example, my resume has 3 different share links that I have sent to different people, all read only and with no expiry. I needed to remove one of them but I had no way to know which one was for whom. This happens pretty often where I share multiple links for each file or folder, each with the same settings but for different people, but really struggle to know which share link went to whom. When I want to remove them.

One idea, to maybe combine both options: could we have something where the note to self is more of a "share title"? If you don't put anything there, the message shown is what @jancborchardt came up with, but if you put a title, it shows that instead? Let me see if I can make a quick prototype of that idea.

So usually, it would say something like

Share link
Read-only, expires in 5 days

but if you put a message on it, for example, "for best friend", then it says:

Share link
for best friend

[gary-kim]

Oh wait, didn't notice this, there's a label system for link shares already. Could we maybe just expose editing that to the user?

server/apps/files_sharing/src/components/SharingEntryLink.vue

Lines 415 to 417 in 264ce21

	if (this.share.label && this.share.label.trim() !== '') {
	return this.share.label
	}

server/apps/files_sharing/lib/Controller/ShareAPIController.php

Lines 1087 to 1089 in 264ce21

	// only link shares have labels
	if ($share->getShareType() === IShare::TYPE_LINK && $label !== null) {
	$share->setLabel($label);

cc @skjnldsv

[rullzer]

Oh wait, didn't notice this, there's a label system for link shares already. Could we maybe just expose editing that to the user?

server/apps/files_sharing/src/components/SharingEntryLink.vue

Lines 415 to 417 in 264ce21

	if (this.share.label && this.share.label.trim() !== '') {
	return this.share.label
	}

server/apps/files_sharing/lib/Controller/ShareAPIController.php

Lines 1087 to 1089 in 264ce21

	// only link shares have labels
	if ($share->getShareType() === IShare::TYPE_LINK && $label !== null) {
	$share->setLabel($label);

cc @skjnldsv

yes please!
Making this editable would be awesome!

The stuff that jan proposes is a next step I guess (having some context below the link)

[jancborchardt]

Oh wait, didn't notice this, there's a label system for link shares already. Could we maybe just expose editing that to the user?

Oh cool, sure. :) Then we could just show that note in parentheses behind like:

Share link (for professor)

Share link (for Alex)

This would then also work for the future if we get that subline with the further info.
Let’s make it a single input field instead of textarea to force people to keep it short. :)

[gary-kim]

Let’s make it a single input field instead of textarea to force people to keep it short. :)

To do that properly, a change will be required in nextcloud-vue as well. I'll get on that.

Also, I'm definitely not going to keep my messages short :)

[jancborchardt]

Also, I'm definitely not going to keep my messages short :)

Hehe ;D You’re free to do that of course, I just think that we have to keep in mind where they would need to be displayed – and those will likely be 1-line displays only mostly. Of course people can write more in an input field.

[gary-kim]

Okay, this is what I've got now (turns out no upstream change is required 😄 ):

[tobiasKaminsky]

Oh cool, sure. :) Then we could just show that note in parentheses behind like:

Share link (for professor)
Share link (for Alex)

Isn't this some kind of redundant? User sees via icon and as they created it themselves that it is a share link.
So I would instead let the user replace the full text.
This then also helps a bit with longer names.

Btw: I created a feature parity issue: #21593

[gary-kim]

Thanks @tobiasKaminsky

Also, ping for reviews?

[jancborchardt]

Isn't this some kind of redundant? User sees via icon and as they created it themselves that it is a share link.
So I would instead let the user replace the full text.

Remember that not everyone spends so much time in Nextcloud as we do. :) So I would still say we should keep the "Share link" text and only put the label inside parentheses behind that.

That is, @gary-kim in your example the "for" is outside of the parentheses but it should not be, basically it’s:

Share link (custom text here)

[gary-kim]

That is, @gary-kim in your example the "for" is outside of the parentheses but it should not be, basically it’s:

Share link (custom text here)

Okie, fixed 👍

[tobiasKaminsky]

On Android it looks like this:

(with primary color themed to black)

[jancborchardt]

Looks good design-wise! :)

[skjnldsv]

See comments :)

[rullzer]

Good stuff! Seems to do the trick. I'm all for getting in and fixing small stuff later in followups!

[gary-kim]

Okay, otherwise good?

[gary-kim]

Rebased

[jospoortvliet]

Great work @gary-kim - I think this will make a lot of users happy ;-)