Catch all exceptions when an app is registering or booting #21461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
rullzer,
anagromataf,
jbtbnl,
kesselb,
Faldon and
PatrycjaPuczko
kesselb
approved these changes
Jun 17, 2020
ChristophWurst
added a commit
that referenced
this pull request
Jun 18, 2020
My patch at #21461 had a little error in that it exits the method when a query exception is encountered during the register step of an app. What we actually want is to continue with the next app and finish the overall registration procedure. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #20865